tokio-quiche: attach additional context when propagating errors.#2304
Closed
tokio-quiche: attach additional context when propagating errors.#2304
Conversation
toidiu
commented
Jan 8, 2026
toidiu
force-pushed
the
akothari/propagate_quiche_error
branch
from
f8983dd to
ff81b94
Compare
toidiu
force-pushed
the
akothari/propagate_quiche_error
branch
2 times, most recently
from
372f13e to
a7d7c42
Compare
toidiu
force-pushed
the
akothari/propagate_quiche_error
branch
3 times, most recently
from
514f239 to
f9227ca
Compare
toidiu
changed the title
toidiu
force-pushed
the
akothari/propagate_quiche_error
branch
from
f9227ca to
75a6f92
Compare
toidiu
force-pushed
the
akothari/propagate_quiche_error
branch
from
75a6f92 to
d16c6c0
Compare
LPardue
reviewed
Jan 12, 2026
| }); | ||
|
|
||
| let actions = vec![ | ||
| Action::SendDatagram { payload: vec![] }, |
Contributor
There was a problem hiding this comment.
The error below seems to be for an invalid DATA frame, so it seems like we don't need this datagram action.
Contributor
Author
There was a problem hiding this comment.
The error seems to trigger only when I first send a Datagram frame. I think this works since I can send an arbitrary payload in the datagram frame and therefore mess with the server state.
LPardue
reviewed
Jan 12, 2026
| segment_size, | ||
| ) | ||
| .map_err(|err| { | ||
| let msg = "Error writing packet. Opt: `AOQ::write_packet_to_buffer`"; |
Contributor
Author
There was a problem hiding this comment.
operation. i'll change the format so its more obvious.
Contributor
Author
|
replaced with #2307 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.