fix: send MAX_STREAMS when available <= 50% of initial for long lived connections#2251
Merged
ghedo merged 5 commits intocloudflare:masterfrom Feb 16, 2026
Merged
fix: send MAX_STREAMS when available <= 50% of initial for long lived connections#2251ghedo merged 5 commits intocloudflare:masterfrom
ghedo merged 5 commits intocloudflare:masterfrom
Conversation
… connections The current logic sends MAX_STREAMS too aggressively. As the next MAX_STREAMS value increases, the condition for whether or not to send MAX_STREAMS becomes unconditionally true. This change fixes that so that MAX_STREAMS is only sent when 50% or more streams have completed.
ghedo
reviewed
Nov 20, 2025
ghedo
reviewed
Nov 20, 2025
ghedo
approved these changes
Nov 20, 2025
antoniovicente
approved these changes
Feb 16, 2026
Contributor
antoniovicente
left a comment
antoniovicente
left a comment
There was a problem hiding this comment.
Thanks for this amazing fix. And sorry for not noticing the full impact of this change until recently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current logic sends MAX_STREAMS too aggressively. As the next MAX_STREAMS value increases, the condition for whether or not to send MAX_STREAMS becomes unconditionally true. This change fixes that so that MAX_STREAMS is only sent when 50% or more streams have completed.