Make H2 response header reads cancellation safe - #944
Draft
Pybsama wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #934.
What this changes
Http2Session::read_response_header()now drives the existingpoll_read_response_header()state machine throughstd::future::poll_fn.That poll path restores the pending
ResponseFutureto the session beforeyielding, so an internal read timeout or external future cancellation cannot
drop the only continuation while leaving the session alive.
The existing timeout error and H2 response-error mappings are unchanged.
Tests
Added in-memory HTTP/2 regressions that:
Http2Session::read_timeout, then resume and read a delayed200 response;
the same delayed response.
Local validation:
cargo test -p pingora-core --libcargo test -p pingora-core --lib --bins --tests --no-fail-fastcargo test -p pingora-core --doccargo check --workspacecargo fmt --all -- --checkcargo clippy -p pingora-core --lib -- --allow=unknown-lints --deny=warningsThe full
pingora-corelibrary result was 481 passed, 1 ignored, 0 failed.