feat(listeners): add add_endpoint_with_filter for granular per-address L4 filtering - #941
Open
zsweiter wants to merge 1 commit into
Open
Conversation
… connection filtering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces
add_endpoint_with_filterto theListenersstruct, allowing developers to configure specificConnectionFilters on individual L4 transport stacks rather than enforcing a single global filter across all listeners.Context / Rationale
Currently, the
Listenersstruct only exposesset_connection_filter, which eagerly iterates over all existingTransportStackBuilderentries and overwrites their local filter option.However,
TransportStackBuilderwas already designed internally to hold an individualOption<Arc<dyn ConnectionFilter>>. The current public API layer forces all listening endpoints (e.g., port 80 and port 5050) to share the exact same L4 drop/accept logic, making it impossible to apply strict L4 firewalling to a management port while keeping the public service port uninhibited within the sameService.By exposing
add_endpoint_with_filter, we leverage Pingora's existing low-level architecture to support granular per-address filtering without breaking backward compatibility. The traditionaladd_endpointsimply defaults to passingNone.Example Usage
Example Usage via
endpoints()This is particularly powerful when configuring a proxy service using the
.endpoints()accessor to bind multiple network ports under a single server runtime: