fix(docs): add missing Badge success examples#194
Closed
singkia wants to merge 2 commits intocloudflare:mainfrom
Closed
fix(docs): add missing Badge success examples#194singkia wants to merge 2 commits intocloudflare:mainfrom
singkia wants to merge 2 commits intocloudflare:mainfrom
Conversation
geoquant
requested changes
Mar 13, 2026
Collaborator
geoquant
left a comment
There was a problem hiding this comment.
hey thank you, if you make changes to packages/kumo a changeset is required. please don't bypass the pre commit hooks
Contributor
Author
|
Added a patch changeset for the changes in this PR. Thanks for catching that. |
Contributor
Author
|
Added a patch changeset for the @cloudflare/kumo changes in this PR. Thanks for catching that. |
Collaborator
|
ah i'm so sorry, someone got to this one: #239 closing since it's merged. again, sorry. and thank you for help! |
Contributor
Author
|
Thanks for the update, and no worries at all. Glad the issue is fixed in #239. Appreciate the follow-up and thanks again for taking a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
successvariant to the Badge docs overview snippetTesting
Notes
successin the overview snippet, variants section, and API reference