Skip to content

fix(docs): add missing Badge success examples#194

Closed
singkia wants to merge 2 commits intocloudflare:mainfrom
singkia:codex/badge-success-docs
Closed

fix(docs): add missing Badge success examples#194
singkia wants to merge 2 commits intocloudflare:mainfrom
singkia:codex/badge-success-docs

Conversation

@singkia
Copy link
Copy Markdown
Contributor

@singkia singkia commented Mar 6, 2026

Summary

  • add the missing success variant to the Badge docs overview snippet
  • add a dedicated Success example to the Badge variants section
  • regenerate Badge metadata and add a regression test covering docs + registry alignment

Testing

  • pnpm --filter @cloudflare/kumo exec vitest run --project=unit tests/docs/badge-docs.test.ts

Notes

  • local screenshot verified the Badge page now shows success in the overview snippet, variants section, and API reference
  • broader typecheck/dev issues in this checkout are pre-existing (echarts dependency resolution and docs dev env setup)

Copy link
Copy Markdown
Collaborator

@geoquant geoquant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey thank you, if you make changes to packages/kumo a changeset is required. please don't bypass the pre commit hooks

@singkia
Copy link
Copy Markdown
Contributor Author

singkia commented Mar 14, 2026

Added a patch changeset for the changes in this PR. Thanks for catching that.

@singkia
Copy link
Copy Markdown
Contributor Author

singkia commented Mar 14, 2026

Added a patch changeset for the @cloudflare/kumo changes in this PR. Thanks for catching that.

@geoquant
Copy link
Copy Markdown
Collaborator

ah i'm so sorry, someone got to this one: #239

closing since it's merged. again, sorry. and thank you for help!

@geoquant geoquant closed this Mar 17, 2026
@singkia
Copy link
Copy Markdown
Contributor Author

singkia commented Mar 17, 2026

Thanks for the update, and no worries at all. Glad the issue is fixed in #239. Appreciate the follow-up and thanks again for taking a look.

@singkia singkia deleted the codex/badge-success-docs branch March 17, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants