feat(kumo): add ColorPicker component with parity UI and eyedropper#174
Closed
singkia wants to merge 1 commit intocloudflare:mainfrom
Closed
feat(kumo): add ColorPicker component with parity UI and eyedropper#174singkia wants to merge 1 commit intocloudflare:mainfrom
singkia wants to merge 1 commit intocloudflare:mainfrom
Conversation
4a4cf3d to
25a469d
Compare
Contributor
Author
|
Updated this PR to keep the scope focused on ColorPicker. What changed in this revision:
Validation I ran locally:
So PR 174 should now represent only the ColorPicker work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ColorPickercomponent to@cloudflare/kumowith parity UI/behavior from the production implementationColorobject state for stable drag/edit interactionsFiles
packages/kumo/src/components/color-picker/*(new module: component, primitives, state bridge, tests, exports)packages/kumo/src/index.ts(main export)packages/kumo/vite.config.ts(component entry)packages/kumo/package.json+pnpm-lock.yaml(dependency + export path).changeset/olive-ladybugs-type.mdValidation
pnpm --filter @cloudflare/kumo typecheckpnpm --filter @cloudflare/kumo exec vitest run src/components/color-picker/color-picker.test.tsxpnpm --filter @cloudflare/kumo exec oxlint --config .oxlintrc.json src/components/color-picker src/index.ts --type-awarepnpm --filter @cloudflare/kumo exec eslint src/components/color-picker src/index.tsNotes
before:bg-white)