fix(ingress): match hostnames case-insensitively (RFC 4343) - #1716
Open
winklemad wants to merge 1 commit into
Open
fix(ingress): match hostnames case-insensitively (RFC 4343)#1716winklemad wants to merge 1 commit into
winklemad wants to merge 1 commit into
Conversation
matchHost compared hostnames with == / strings.HasSuffix without normalizing case, but hostnames are case-insensitive (RFC 4343, RFC 3986 3.2.2). validateHostname accepts mixed-case hostnames, and req.Host reaches matching un-lowercased, so a mixed-case Host or config hostname would skip the intended rule and fall through to the catch-all. Lower-case both sides; add direct + end-to-end tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1715.
Ingress rule matching was case-sensitive, but hostnames are case-insensitive (RFC 4343; RFC 3986 §3.2.2).
matchHostcompared with==/strings.HasSuffixwithout normalizing case, andvalidateHostnameaccepts mixed-case hostnames — so a config likehostname: MyApp.example.com, or any mixed-case requestHostreachingproxy.go, would skip the intended rule and fall through to the catch-all.This lower-cases both sides in
matchHost, matching how every other HTTP router (nginx, Caddy, Envoy, Traefik) treats hostnames.Adds
TestMatchHostCaseInsensitive(direct) andTestFindMatchingRuleCaseInsensitive(end-to-end); both fail onmainand pass with the fix.go test ./ingress/andgo vet ./ingress/are clean.