fix: remove invalid :global() pseudo-class in agent-setup.css#32262
Open
mvvmm wants to merge 1 commit into
Open
fix: remove invalid :global() pseudo-class in agent-setup.css#32262mvvmm wants to merge 1 commit into
mvvmm wants to merge 1 commit into
Conversation
'.agent-setup-troubleshooting-solution-body :global(code)' uses Astro/Vue-style :global() scoping syntax inside a plain global stylesheet, where it has no meaning. lightningcss (Vite's CSS minifier) correctly warns this isn't a recognized pseudo-class. This selector is also the last thing that ever logs during Workers Builds preview builds before they hang and eventually hit the 20-minute build timeout -- every single preview build for weeks has stalled immediately after lightningcss processes this exact rule. Removing the invalid :global() wrapper (this file has no scoping to escape from in the first place) to see if it resolves the hang.
Contributor
Review✅ No issues found in commit Code ReviewThis code review is in beta and may not always be helpful — use your judgment. No code review issues found. ConventionsNo convention issues found. Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
|
Preview URL: https://99827fb4.preview.developers.cloudflare.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.agent-setup-troubleshooting-solution-body :global(code)uses Astro/Vue-style:global()scoping syntax inside a plain global stylesheet (src/styles/agent-setup.css), where it has no meaning — this file isn't a scoped Astro component<style>block.lightningcss(Vite's CSS minifier) correctly flags it:'global' is not recognized as a valid pseudo-class.