fix: More robust head SHA validation in auto format workflow#31255
Open
AaronDewes wants to merge 1 commit into
Open
fix: More robust head SHA validation in auto format workflow#31255AaronDewes wants to merge 1 commit into
AaronDewes wants to merge 1 commit into
Conversation
AaronDewes
requested review from
a team,
MohamedH1998,
ahaywood,
colbywhite,
kodster28 and
mvvmm
as code owners
Contributor
Review✅ No style-guide issues found in commit CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
AaronDewes
force-pushed
the
improve-auto-format
branch
from
5aaed5b to
fe77d2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This makes the auto format workflow obtain the head SHA from the PR that triggered the workflow run directly.
This improves security because even if an attacker managed to upload a malicious artifact by manipulating their PR, they could no longer abuse that to push to arbitrary PRs because the SHA sum wouldn't match.
Screenshots (optional)
Documentation checklist
Not applicable.