Skip to content

[Logs] Update Logpush dataset field definitions (2026-06-04)#31228

Open
soheiokamoto wants to merge 1 commit into
productionfrom
sync/log-fields-2026-06-04
Open

[Logs] Update Logpush dataset field definitions (2026-06-04)#31228
soheiokamoto wants to merge 1 commit into
productionfrom
sync/log-fields-2026-06-04

Conversation

@soheiokamoto
Copy link
Copy Markdown
Contributor

Summary

Automated sync of Logpush dataset field definitions from data/entities.

Files changed

  • src/content/docs/logs/logpush/logpush-job/datasets/{account,zone}/ — dataset pages

Documentation checklist

  • Changelog entry — not applicable (no field additions or removals)
  • Content generated by code generator (DO NOT EDIT manually)

@soheiokamoto soheiokamoto requested a review from rianvdm as a code owner June 4, 2026 06:41
@soheiokamoto
Copy link
Copy Markdown
Contributor Author

/bonk please review this automated sync of Logpush dataset field definitions.

Focus on the following:

  1. Changelog quality — is the entry clear, accurate, and useful to end users?

  2. Field description quality — are the descriptions accurate, clear, and complete?

  3. Manual edits at risk of being overwritten — are there any field descriptions that appear
    to have been manually edited directly in cloudflare-docs (e.g. contain context or guidance
    not present in the machine-generated description format)? If so, flag them so the author can
    preserve those edits in the internal source YAML.

@soheiokamoto soheiokamoto requested a review from a team as a code owner June 4, 2026 06:41
@cloudflare-docs-bot
Copy link
Copy Markdown
Contributor

cloudflare-docs-bot Bot commented Jun 4, 2026

Review

✅ No style-guide issues found in commit fbd0453.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/docs/logs/ @soheiokamoto, @angelampcosta, @rianvdm, @dcpena, @cloudflare/product-owners

@ask-bonk ask-bonk Bot added the documentation Documentation edits label Jun 4, 2026
Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues. The sync correctly replaces e.g. with for example per the style guide, and marking the changelog as N/A is appropriate for a wording-only change. No manual edits in cloudflare-docs appear at risk of being overwritten.

Out of scope: This generated file lacks the description frontmatter required for all pages with pcx_content_type. Consider updating the generator template to include it.

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Jun 4, 2026

Review complete for PR #31228.

What changed
One line updated in src/content/docs/logs/logpush/logpush-job/datasets/zone/http_requests.md: the MatchedRules field description now uses for example instead of e.g.. This aligns with the Cloudflare style guide (Replace e.g. with "for example").

Assessment

  • Changelog: N/A is correct. A wording-only fix in an existing field description does not require a changelog entry.
  • Field description quality: Accurate and follows the style guide. No concerns.
  • Manual edits at risk: None. This is a clean generated change with no evidence of overwriting manual edits made directly in cloudflare-docs.

Labels applied

  • documentation
  • product:logs
  • size/xs

Note for maintainers
The generated file is missing the description frontmatter, which the style guide requires for all pages with pcx_content_type. I flagged this in the review comment as an out-of-scope issue for the generator template — it doesn't block this PR.

github run

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation edits product:logs Related to Logs size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants