fix(workers-ai-provider): remove tool_call_id sanitization#446
Merged
threepointone merged 1 commit intomainfrom Mar 18, 2026
Merged
fix(workers-ai-provider): remove tool_call_id sanitization#446threepointone merged 1 commit intomainfrom
threepointone merged 1 commit intomainfrom
Conversation
Remove the sanitizeToolCallId helper and the code that normalized tool_call_id and tool_calls[].id to a 9-char alphanumeric form. That truncation caused different IDs to collide after a round-trip, so the sanitization was removed to preserve original IDs. Tests were updated: sanitizeToolCallId unit tests were removed, normalizeMessagesForBinding tests now assert tool_call_id and tool_calls[].id are passed through unchanged, add a test for null content -> empty string, and adjust mutation checks. A changeset was added to publish this as a patch.
🦋 Changeset detectedLatest commit: 3c35051 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sanitizeToolCallId()which truncated all tool call IDs to 9 alphanumeric chars, causing every tool call ID to collide tochatcmpltafter round-tripnormalizeMessagesForBinding()to only handlecontent: null → ""normalizationThis mirrors the same fix applied to
@cloudflare/tanstack-aiin #424. The binding's[a-zA-Z0-9]{9}validation has been relaxed upstream, confirmed by e2e tool round-trip tests passing across all 10 models without sanitization.Test plan
Made with Cursor