fix(contrib): resolve slog.Default() lazily to respect LOG_LEVEL=debug#69
Open
arnaugiralt wants to merge 1 commit intomasterfrom
Open
fix(contrib): resolve slog.Default() lazily to respect LOG_LEVEL=debug#69arnaugiralt wants to merge 1 commit intomasterfrom
arnaugiralt wants to merge 1 commit intomasterfrom
Conversation
Contrib components were capturing slog.Default() at construction time and storing it as a struct field. Because plugins are constructed before chaperone.Run() calls configureLogging(), all contrib debug logs were silently discarded when LOG_LEVEL=debug was set. Replace the eager-capture pattern with a log() helper method on each struct that calls slog.Default() at emit time. An explicit Logger in the config is used as-is; a nil Logger defers to whichever logger is currently installed globally. Affected construction sites: - mux.go: NewMux() no longer pre-captures slog.Default() - static_mapping.go: NewStaticMapping() no longer pre-captures slog.Default() - microsoft/token.go: NewRefreshTokenSource() no longer pre-captures slog.Default() - oauthutil/token.go: NewTokenFetcher() no longer pre-captures slog.Default() - oauth/token.go: tokenManager.log() added for lazy resolution - oauth/refreshtoken.go: RefreshToken.log() added for lazy resolution Fixes LITE-33931. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
qarlosh
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contrib components were capturing slog.Default() at construction time and storing it as a struct field. Because plugins are constructed before chaperone.Run() calls configureLogging(), all contrib debug logs were silently discarded when LOG_LEVEL=debug was set.
Replace the eager-capture pattern with a log() helper method on each struct that calls slog.Default() at emit time. An explicit Logger in the config is used as-is; a nil Logger defers to whichever logger is currently installed globally.
Affected construction sites:
Fixes LITE-33931.