Skip to content

verify: Handle version strings with special characters#1226

Merged
ono-max merged 1 commit intomainfrom
fix-verify-command
Feb 4, 2026
Merged

verify: Handle version strings with special characters#1226
ono-max merged 1 commit intomainfrom
fix-verify-command

Conversation

@ono-max
Copy link
Contributor

@ono-max ono-max commented Feb 2, 2026

The verify command is failing when special characters is included in version strings, e.g. such as "3.13.0+". This PR addresses it.

smart-tests verify 
Organization: 'launchableinc'
Workspace: 'test-for-percona-psmdb'
Proxy: None
Platform: 'macOS-15.7.3-arm64-arm-64bit-Mach-O'
Python version: '3.13.3+'
Java command: 'java'
smart-tests version: '2.3.0'
Traceback (most recent call last):
  File "/Users/ono-max/.pyenv/versions/3.13-dev/bin/smart-tests", line 8, in <module>
    sys.exit(main())
             ~~~~^^
  File "/Users/ono-max/.pyenv/versions/3.13-dev/lib/python3.13/site-packages/smart_tests/__main__.py", line 56, in main
    cli.main()
    ~~~~~~~~^^
  File "/Users/ono-max/.pyenv/versions/3.13-dev/lib/python3.13/site-packages/smart_tests/args4p/command.py", line 129, in main
    self(*args)
    ~~~~^^^^^^^
  File "/Users/ono-max/.pyenv/versions/3.13-dev/lib/python3.13/site-packages/smart_tests/args4p/command.py", line 109, in __call__
    r = invoker.invoke()
  File "/Users/ono-max/.pyenv/versions/3.13-dev/lib/python3.13/site-packages/smart_tests/args4p/command.py", line 664, in invoke
    return self.command.callback(self.parent.invoke(), **self.kwargs)
           ~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ono-max/.pyenv/versions/3.13-dev/lib/python3.13/site-packages/smart_tests/commands/verify.py", line 125, in verify
    if compare_version([int(x) for x in platform.python_version().split('.')], [3, 6]) < 0:
                        ~~~^^^
ValueError: invalid literal for int() with base 10: '3+'

@ono-max ono-max requested review from Konboi and gayanW February 2, 2026 04:58
@ono-max ono-max merged commit 479b3dd into main Feb 4, 2026
2 checks passed
@ono-max ono-max deleted the fix-verify-command branch February 4, 2026 00:42
@github-actions github-actions bot mentioned this pull request Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants