Merged
Conversation
ono-max
reviewed
Jan 29, 2026
Contributor
|
Just out of curiosity, why do you wanna configure the regular expression instead of glob patterns? I believe glob patterns are more common for filename pattern matching? |
Co-authored-by: Naoto Ono <nono@cloudbees.com>
Contributor
Author
My motivation for this PR is to exclude specific packages. test_path = file2class_test_path(f)
for pattern in compiled_exclude_rules:
if pattern.search(test_path[0]["name"]):
return NoneIn this context, Java package names are not file paths e.g.) That's why I chose the regexp instead of glob patterns. Does this make sense? |
Contributor
|
It does make sense. Thank you for your explanation! |
ono-max
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When using
launchable subset maven, there was no way to exclude specific packages (e.g., e2e tests) from the subset. Users needed a way to filter out certain test patterns using regular expressions.What
--excludeoption to the maven subset command--excludeoptions can be specified to exclude multiple patternsUsage example