Conversation
ono-max
reviewed
Jan 22, 2026
Comment on lines
116
to
122
| os.unlink(zip_path) | ||
| os.unlink(tar_path) | ||
| os.unlink(text_file_1) | ||
| os.unlink(text_file_2) | ||
| os.unlink(binary_file) | ||
| os.rmdir(os.path.dirname(text_file_2)) | ||
| os.rmdir(temp_dir) |
Contributor
There was a problem hiding this comment.
If you use tempfile.TemporaryDirectory(), all its contents are automatically cleaned up.
ono-max
reviewed
Jan 22, 2026
ono-max
approved these changes
Jan 22, 2026
Contributor
ono-max
left a comment
There was a problem hiding this comment.
Approved this PR not to block you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The record attachment command is updated to also support zip files.
Let says user have the following files:
Usage: