Open
Conversation
Contributor
Author
|
c.c. @NicuPascu |
93ba07c to
878c217
Compare
kohsuke
approved these changes
Dec 5, 2025
Contributor
kohsuke
left a comment
There was a problem hiding this comment.
Thanks for taking care of this so quickly!
- In Python's function calling convention, arguments can be partially positional (what Python calls
args) and partially keyword based (what Python callskwargs), for examplef(1,2,a=3)so assuming this metadata follows the same scheme, this code could see both of them at the same time. If that happens, this simply drops the positional arguments, which would be hard to notice. If you choose to handle this, I suppose the easiest is to just concatenate both args and kwargs. Python invocation syntax(1,2,a=3)would be probably nicer in terms of visualization, but it's bit more effort processing. Maybe Claude Code could write that for us? - I believe the test dependency mechanism that some customers rely on are built on this metadata. If so, I'd imagine we need to update the server side first to be able to deal with both forms, before we roll out this change.
NicuPascu
approved these changes
Dec 5, 2025
NicuPascu
left a comment
There was a problem hiding this comment.
LGTM 🐝
Can we go through the DB and update the format of the all the old markers as well or should we support both data structures?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After