Support migrating volumes_info entries with legacy disk ids#467
Merged
Conversation
Dany9966
requested changes
Jul 3, 2026
| new_disk_id = legacy_ids_map.get(disk_id) | ||
| if not new_disk_id: | ||
| continue | ||
| if new_disk_id in existing_volume_disk_ids: |
Contributor
There was a problem hiding this comment.
This is an odd edge-case, basically pretending like a volume can be attached twice to the same VM. Or there's a UUID conflict. It's fine for now.
fabi200123
force-pushed
the
disk-uuid-identifiers
branch
from
b35d777 to
449bc70
Compare
Dany9966
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the logic required to not delete and replicate again the disks if the disk_id gets updated, but referencing the same disk that can be checked via the legacy_ids options.