Track worker occupancy in stats - #377
Draft
neob91-close wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
utilizationstat counts only time inside task code, so a worker saturated with many short tasks reads well below 100% — the dequeue/scan/lock overhead between tasks is invisible. This broke utilization-based autoscaling for us: workers scaled down during a large backlog.Adds
time_idle(blocking waits for new work, measured viameasure_idle()around the two wait sites), and emitstime_overheadandoccupancy = 100 * (total - idle) / total— the "can this worker take more work" signal. Purely additive:utilizationandtime_busykeep their meaning.Caveat for consumers that monkey-patch
StatsThread(custom stats adapters): the worker now callsmeasure_idle()/report_idle_*, so adapters need those methods.