Package ci-smoketests binary in smoketests build - #5739
Merged
joshua-spacetime merged 3 commits intoAug 14, 2026
Conversation
joshua-spacetime
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
August 13, 2026 20:47
joshua-spacetime
removed this pull request from the merge queue due to a manual request
Aug 14, 2026
joshua-spacetime
deleted the
joshua/ci/fix/compilation-in-smoketest-shards
branch
August 14, 2026 01:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Accidentally reverted in #5687.
I noticed execution times for the smoketest shards increased after #5687, and I saw they were compiling the
ci-smoketestsbinary instead of packaging it with the smoketests build.API and ABI breaking changes
N/A
Expected complexity level and risk
1
Testing
N/A