Enforce rollback safety PR checks - #5731
Open
bfops wants to merge 68 commits into
Open
Conversation
This reverts commit 2c10c76.
…rgo-ci-merge-5687 # Conflicts: # tools/ci/README.md # tools/ci/src/main.rs
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
bfops
commented
Aug 13, 2026
| echo "This PR is not based on master. Please wait until the base PR merges." | ||
| exit 1 | ||
|
|
||
| release_dependencies: |
Collaborator
Author
There was a problem hiding this comment.
this is an odd place to add this job, but this is kind of where we have put job(s) that depend on PR metadata rather than just commit contents. Thoughts? ci.yml doesn't run on PR edit events, but this workflow does
bfops
commented
Aug 13, 2026
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
bfops
commented
Aug 13, 2026
| on: | ||
| pull_request: | ||
| types: [opened, edited] | ||
| types: [opened, reopened, edited] |
Collaborator
Author
There was a problem hiding this comment.
unrelated fix: run properly on reopened PRs
…ub.com:clockworklabs/SpacetimeDB into bfops/rollback-safety
bfops
commented
Aug 13, 2026
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.event.inputs.pr_number || format('sha-{0}', github.sha) }} | ||
| cancel-in-progress: true |
Collaborator
Author
There was a problem hiding this comment.
unrelated fix: have later jobs cancel previous ones, e.g. if you edit the PR description several times quickly
bfops
marked this pull request as ready for review
August 13, 2026 18:28
… into bfops/rollback-safety
… into bfops/rollback-safety
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This is the first PR in what will be a small series of PRs geared at enforcing our strategy for rollback-safe deploys.
Updates the PR template with a new section for noting PRs that must be released before the current PR can merge. We also add a CI check that this field has been updated, and to enforce that those PRs have actually been released.
Also adds a separate utility for finding what release included a particular PR. This is based on commit subject lines, so it can technically be spoofed.
API and ABI breaking changes
None
Expected complexity level and risk
2
Must be released
Testing