Supply empty arg hash for anonymous views at runtime#5449
Open
joshua-spacetime wants to merge 1 commit into
Open
Supply empty arg hash for anonymous views at runtime#5449joshua-spacetime wants to merge 1 commit into
joshua-spacetime wants to merge 1 commit into
Conversation
Instead of baking it into the query plan. The query plan should parameterize anonymous views just like sender-scoped views.
Contributor
|
Maybe this does not make sense but could thr anonymous case not just br handled as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Instead of baking it into the query plan. The query plan should parameterize anonymous views just like sender-scoped views. We need this for the next step which is plan sharing for subscriptions.
API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
Existing coverage