[C#] [Unity 6] Added logic to use either getWasmTableEntry or dynCall for C# WebGL#4961
Open
[C#] [Unity 6] Added logic to use either getWasmTableEntry or dynCall for C# WebGL#4961
getWasmTableEntry or dynCall for C# WebGL#4961Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This is a fix for #4959.
Unity 6 upgraded to a newer Emscripten version that removed the
dynCall()library function. The SpacetimeDB C# SDK's WebSocket.jslib plugin useddynCall()in 6 places to invoke C# callbacks from JavaScript WebSocket events.This PR adds a
$WebSocketDynCallhelper function that detects which API is available at runtime:getWasmTableEntry(ptr).apply(null, args)(direct WASM function table access)dynCall(sig, ptr, args)All
dynCallcall sites inWebSocket.jslibnow route through this helper, ensuring we maintain backward-compatiblity.API and ABI breaking changes
No breaking changes. This is a backward-compatible fix that works on both older and newer Unity versions.
Expected complexity level and risk
jslibplugin and uses runtime feature detection to choose the appropriate calling mechanism. Both code paths are well-tested:dynCallpathgetWasmTableEntrypathTesting
dynCall is not defined)