Fix TypeScript optional row keys#4940
Open
clockwork-labs-bot wants to merge 3 commits intomasterfrom
Open
Conversation
bfops
reviewed
May 4, 2026
bfops
reviewed
May 4, 2026
bfops
reviewed
May 4, 2026
Collaborator
Author
|
Following up on the latest review comments here: you were right that the previous typecheck coverage should not have been narrowed away. I pushed
So the new coverage is additive now, not a replacement. Local |
Collaborator
|
I think this should have some kind of smoketest for some of the code that used to fail. And it should be reviewed by someone who is more familiar with this part of the code. It seems generally good though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix TypeScript row inference so
.optional()fields become optional object keys instead of required keys whose values may beundefined.This addresses the reducer/view parameter typing issue from
#4516, where callers had to explicitly passundefinedfor omitted optional fields.This is a fresh bot-owned replacement for stalled PR
#4518.Changes
InferTypeOfRowtscover the.test-d.tscoveragetable_cacheindexing to satisfy the stricter inferred row shapeExample
Before:
After:
Closes #4516.
Validation
pnpm test:typecheckpnpm test