[Rust] Primary keys for query builder views#4572
Open
joshua-spacetime wants to merge 4 commits intomasterfrom
Open
[Rust] Primary keys for query builder views#4572joshua-spacetime wants to merge 4 commits intomasterfrom
joshua-spacetime wants to merge 4 commits intomasterfrom
Conversation
d4a6819 to
ab19a38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Query builder views return a subset of rows from a physical table. If that table has a primary key, then so should the view. What this means concretely is that the view should expose the same api as the table, specifically as it relates to the primary key column.
With that in mind, this patch commits the following changes:
ViewDefwith aprimary_keyon_updatefor such viewsAPI and ABI breaking changes
None
Expected complexity level and risk
3
Testing
on_updatefor PK views and semijoin scenarios