Export Range/Bound from the spacetimedb/server in the Typescript sdk#4567
Open
dusk125 wants to merge 5 commits intoclockworklabs:masterfrom
Open
Export Range/Bound from the spacetimedb/server in the Typescript sdk#4567dusk125 wants to merge 5 commits intoclockworklabs:masterfrom
dusk125 wants to merge 5 commits intoclockworklabs:masterfrom
Conversation
Contributor
|
@dusk125 Could you make these explicit exports please? If so I can merge it! |
Collaborator
|
@dusk125 Tyler's asking for explicit exports instead of -export * from './range';
+export { Range } from './range';
+export type { Bound } from './range';( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This change exports the Range (and Bound) types so that ranged filtering can be done from Typescript modules. I chose to do export * so that both Range and Bounds are included and I chose to not export as types since the user will need to instantiate a Range for use in a query
API and ABI breaking changes
None
Expected complexity level and risk
1
It seems like this export was just missed as the documentation for range queries makes reference to them, but I was unable to import them as it recommends (or at all)
Testing
At the time of writing, I haven't tested the fix yet, I'll see if I can get a local copy of spacetime built and validate I can now imports Ranges.