Move unity testsuite onto unity runner #4061
Open
+1
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdetter
commented
Jan 19, 2026
|
|
||
| # We need this to support "Docker in Docker" | ||
| - name: Start Docker daemon | ||
| run: /usr/local/bin/start-docker.sh |
Collaborator
Author
There was a problem hiding this comment.
The new runners are very similar to the original github hosted runners - so we don't need docker in docker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The downside here: This will cause jobs to wait which is what we want right now. Jobs may wait to queue for several minutes while other jobs finish but I don't expect this to have a big impact on the total time a PR will spend in the merge queue.
API and ABI breaking changes
None
Expected complexity level and risk
1
Testing