Skip to content

Conversation

@douglance
Copy link

@douglance douglance commented Jan 16, 2026

Description of Changes

Use relative import '../src' in serde.test.ts to match all other test files.

This is a consistency fix. The 'spacetimedb' import works in CI (build runs first, enabling package self-reference), but all other tests use '../src'.

API and ABI breaking changes

None

Expected complexity level and risk

1

Change import from 'spacetimedb' to '../src' to match other test files.
This fixes the test failing to resolve the package entry.
@douglance douglance changed the title fix(ts-sdk): use relative import in serde test chore(ts-sdk): use consistent import style in serde test Jan 16, 2026
@douglance douglance changed the title chore(ts-sdk): use consistent import style in serde test Use consistent import style in serde test Jan 16, 2026
@bfops
Copy link
Collaborator

bfops commented Jan 16, 2026

Hey @douglance, thank you for taking the time to make a contribution!

To minimize noise in the repo, we generally try to avoid small preference-inspired PRs (unless they're specifically bringing us in line with our linter, style guide, etc.)

I hope that's understandable. Please let me know if I've missed something important about the motivation or impact here!

@douglance
Copy link
Author

@bfops This fixes an issue where the tests fail unless the system has been built. It's not a preference thing.

I lost some time trying to figure out why this test was failing on a fresh pull down of the repo.

@douglance douglance changed the title Use consistent import style in serde test Fix test failure in fresh checkout of repository Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants