Skip to content

Improve local dev setup for clinvar-vrsification#35

Open
larrybabb wants to merge 7 commits into
mainfrom
improve-local-dev-setup
Open

Improve local dev setup for clinvar-vrsification#35
larrybabb wants to merge 7 commits into
mainfrom
improve-local-dev-setup

Conversation

@larrybabb

Copy link
Copy Markdown

Summary

  • Add HGVS_SEQREPO_DIR and fake AWS credentials to clinvar-vrsification script to prevent slow NCBI eutils fallback (~30x speedup) and boto3 using real ~/.aws/credentials against the local DynamoDB endpoint
  • Document all required env vars in the script header and README
  • Fix variation-normalizer-compose.yaml to use ${SEQREPO_ROOT_DIR}/.. instead of a hardcoded developer path
  • Refactor main.py __main__ to only require UTA_DB_URL when --liftover is set
  • Pin agct and cool-seq-tool transitive dependencies in pyproject.toml
  • Add buckets/ to .gitignore

Test plan

  • Set required env vars from README and run misc/clinvar-vrsification <release_date>
  • Verify services start with podman-compose -f variation-normalizer-compose.yaml up -d
  • Confirm no NCBI eutils calls in the log output
  • Confirm script runs without UTA_DB_URL set when --liftover is not passed

🤖 Generated with Claude Code

- Add HGVS_SEQREPO_DIR and fake AWS credentials to clinvar-vrsification
  script to prevent slow NCBI eutils fallback and boto3 using real AWS creds
- Document required env vars in script header and README
- Fix variation-normalizer-compose.yaml to use SEQREPO_ROOT_DIR env var
  instead of hardcoded developer path
- Refactor main.py __main__ to only require UTA_DB_URL when --liftover is set
- Pin agct and cool-seq-tool transitive dependencies in pyproject.toml
- Add buckets/ to .gitignore

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the local development experience for running “ClinVar VRS-ification” and related services by standardizing environment configuration, speeding up sequence resolution by forcing local SeqRepo usage, and making liftover-related dependencies optional unless requested.

Changes:

  • Updated local compose setup to mount SeqRepo from a configurable host path instead of a developer-specific hardcoded path.
  • Documented/added required environment variables (including HGVS_SEQREPO_DIR and dummy AWS credentials) to avoid slow network fallbacks and unintended AWS credential usage.
  • Adjusted __main__ startup checks so UTA_DB_URL is only required when --liftover is enabled; added dependency pins and ignored local output buckets.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
variation-normalizer-compose.yaml Replaces a hardcoded SeqRepo host path with a variable-based mount for local dev.
README.md Documents HGVS_SEQREPO_DIR to ensure hgvs uses local SeqRepo instead of NCBI eutils.
pyproject.toml Adds dependency pins to stabilize transitive dependency resolution.
misc/clinvar-vrsification Documents required env vars and sets dummy AWS credentials for local runs.
clinvar_gk_pilot/main.py Makes UTA_DB_URL required only when --liftover is set.
.gitignore Ignores generated buckets/ output directory.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread clinvar_gk_pilot/main.py Outdated
Comment thread clinvar_gk_pilot/main.py
Comment thread README.md Outdated
Comment thread misc/clinvar-vrsification Outdated
Comment thread variation-normalizer-compose.yaml
Comment thread misc/clinvar-vrsification
larrybabb and others added 6 commits June 29, 2026 10:45
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants