Improve local dev setup for clinvar-vrsification#35
Open
larrybabb wants to merge 7 commits into
Open
Conversation
- Add HGVS_SEQREPO_DIR and fake AWS credentials to clinvar-vrsification script to prevent slow NCBI eutils fallback and boto3 using real AWS creds - Document required env vars in script header and README - Fix variation-normalizer-compose.yaml to use SEQREPO_ROOT_DIR env var instead of hardcoded developer path - Refactor main.py __main__ to only require UTA_DB_URL when --liftover is set - Pin agct and cool-seq-tool transitive dependencies in pyproject.toml - Add buckets/ to .gitignore Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR improves the local development experience for running “ClinVar VRS-ification” and related services by standardizing environment configuration, speeding up sequence resolution by forcing local SeqRepo usage, and making liftover-related dependencies optional unless requested.
Changes:
- Updated local compose setup to mount SeqRepo from a configurable host path instead of a developer-specific hardcoded path.
- Documented/added required environment variables (including
HGVS_SEQREPO_DIRand dummy AWS credentials) to avoid slow network fallbacks and unintended AWS credential usage. - Adjusted
__main__startup checks soUTA_DB_URLis only required when--liftoveris enabled; added dependency pins and ignored local output buckets.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| variation-normalizer-compose.yaml | Replaces a hardcoded SeqRepo host path with a variable-based mount for local dev. |
| README.md | Documents HGVS_SEQREPO_DIR to ensure hgvs uses local SeqRepo instead of NCBI eutils. |
| pyproject.toml | Adds dependency pins to stabilize transitive dependency resolution. |
| misc/clinvar-vrsification | Documents required env vars and sets dummy AWS credentials for local runs. |
| clinvar_gk_pilot/main.py | Makes UTA_DB_URL required only when --liftover is set. |
| .gitignore | Ignores generated buckets/ output directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HGVS_SEQREPO_DIRand fake AWS credentials toclinvar-vrsificationscript to prevent slow NCBI eutils fallback (~30x speedup) and boto3 using real~/.aws/credentialsagainst the local DynamoDB endpointvariation-normalizer-compose.yamlto use${SEQREPO_ROOT_DIR}/..instead of a hardcoded developer pathmain.py__main__to only requireUTA_DB_URLwhen--liftoveris setagctandcool-seq-tooltransitive dependencies inpyproject.tomlbuckets/to.gitignoreTest plan
misc/clinvar-vrsification <release_date>podman-compose -f variation-normalizer-compose.yaml up -dUTA_DB_URLset when--liftoveris not passed🤖 Generated with Claude Code