fix(joint-react): paper handling and enhance joint-react features#3382
Open
samuelgja wants to merge 3 commits into
Open
fix(joint-react): paper handling and enhance joint-react features#3382samuelgja wants to merge 3 commits into
samuelgja wants to merge 3 commits into
Conversation
…hook and related updates
- Added support for nullish cell IDs in `useCells` and related hooks, allowing selectors to handle undefined gracefully. - Implemented synchronous notifications for feature registration and unregistration in `GraphStore`, ensuring immediate updates for `useSyncExternalStore` consumers. - Introduced warnings for missing cell setters to prevent silent failures when attempting to update non-existent cells. - Updated tests to cover new behaviors, including synchronous notifications and handling of nullish IDs. - Refactored `setCell`, `setCellData`, and related functions to accept nullish IDs, improving robustness and user experience.
samuelgja
force-pushed
the
fix/paper-fixing-joint-react
branch
from
06dbfba to
aa823e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update joint-react to improve paper lifecycle management, enhance event handling, and streamline API usage. Introduce new features such as reactive paper options, improved data management, and various example enhancements. This change addresses several issues related to performance and usability in the joint-react library.