feature/cp-11495-api-payload-update-android#359
Open
unnaticleverpush wants to merge 2 commits into
Open
Conversation
Adds support for RelativeToDelivery expiration for app banners and introduces clearAllBannerDeliveryDates() and clearBannerDeliveryDate(String bannerId) to clear stored delivery data.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cc200df. Configure here.
There was a problem hiding this comment.
1 issue found across 5 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds support for RelativeToDelivery expiration for app banners and introduces clearAllBannerDeliveryDates() and clearBannerDeliveryDate(String bannerId) to clear stored delivery data.
Note
Medium Risk
Changes which banners are eligible to display and adds durable SharedPreferences state; mistakes could hide banners early or show them too long, but scope is limited to app banner targeting.
Overview
Adds RelativeToDelivery as a banner stop type (
relative_to_delivery/stopAtRelativeDaysfrom the API), so banners can expire a fixed number of days after they are first shown, not only at a fixed calendar time.On first display, the SDK records a per-banner delivery timestamp in SharedPreferences (
APP_BANNER_DELIVERY_DATES). Group listing and the show pipeline now skip banners past that window viaisBannerRelativeToDeliveryAllowed.CleverPush.clearAllBannerDeliveryDates()andclearBannerDeliveryDate(bannerId)let apps reset that stored state (e.g. after config or testing changes).Reviewed by Cursor Bugbot for commit ae2a535. Bugbot is set up for automated code reviews on this repo. Configure here.