Skip to content

feature/cp-11495-api-payload-update-android#359

Open
unnaticleverpush wants to merge 2 commits into
masterfrom
feature/cp-11495-api-payload-update-android
Open

feature/cp-11495-api-payload-update-android#359
unnaticleverpush wants to merge 2 commits into
masterfrom
feature/cp-11495-api-payload-update-android

Conversation

@unnaticleverpush

@unnaticleverpush unnaticleverpush commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Adds support for RelativeToDelivery expiration for app banners and introduces clearAllBannerDeliveryDates() and clearBannerDeliveryDate(String bannerId) to clear stored delivery data.


Note

Medium Risk
Changes which banners are eligible to display and adds durable SharedPreferences state; mistakes could hide banners early or show them too long, but scope is limited to app banner targeting.

Overview
Adds RelativeToDelivery as a banner stop type (relative_to_delivery / stopAtRelativeDays from the API), so banners can expire a fixed number of days after they are first shown, not only at a fixed calendar time.

On first display, the SDK records a per-banner delivery timestamp in SharedPreferences (APP_BANNER_DELIVERY_DATES). Group listing and the show pipeline now skip banners past that window via isBannerRelativeToDeliveryAllowed. CleverPush.clearAllBannerDeliveryDates() and clearBannerDeliveryDate(bannerId) let apps reset that stored state (e.g. after config or testing changes).

Reviewed by Cursor Bugbot for commit ae2a535. Bugbot is set up for automated code reviews on this repo. Configure here.

Adds support for RelativeToDelivery expiration for app banners and introduces clearAllBannerDeliveryDates() and clearBannerDeliveryDate(String bannerId) to clear stored delivery data.
@unnaticleverpush unnaticleverpush self-assigned this Jun 16, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit cc200df. Configure here.

Comment thread cleverpush/src/main/java/com/cleverpush/banner/AppBannerModule.java Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 5 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread cleverpush/src/main/java/com/cleverpush/banner/AppBannerModule.java Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant