feature/cp-11668-add-button-border-customization-for-in-app-banners-android#357
Open
unnaticleverpush wants to merge 2 commits into
Open
Conversation
…ndroid Add configurable border (width, color, solid/dashed/dotted style) to banner buttons
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f3f1475. Configure here.
There was a problem hiding this comment.
2 issues found across 3 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add configurable border (width, color, solid/dashed/dotted style) to banner buttons
Note
Low Risk
UI-only rendering and model parsing; default is no border when width is zero, with no auth or data-path changes.
Overview
Adds configurable button borders for in-app banner and inbox detail carousel buttons, driven by new JSON fields on button blocks.
BannerButtonBlocknow readsborderWidth,borderColor, andborderStyleand exposes getters. Button backgrounds go through a newapplyBorderhelper inAppBannerCarouselAdapterandInboxDetailBannerCarouselAdapter: when width is ≤ 0, behavior stays unchanged (fill only). Otherwise borders use the block’s corner radius and PX scale; solid borders useGradientDrawable.setStroke, while dashed / dotted use a stackedLayerDrawableand software rendering on API 21+. Missing border color defaults to white.Reviewed by Cursor Bugbot for commit 480d134. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by cubic
Adds configurable borders to Android in‑app banner buttons: width, color, and solid/dashed/dotted styles. Aligns with Linear CP‑11668 and keeps current look by default.
BannerButtonBlock: addsborderWidth,borderColor,borderStyleand parses them from JSON.GradientDrawable/LayerDrawable, respects corner radius and PX scale; dashed/dotted require Lollipop+ (fallback to solid) and force software layer; no border when width ≤ 0.AppBannerCarouselAdapterandInboxDetailBannerCarouselAdapter; default border color is white whenborderColoris missing.Written for commit 480d134. Summary will update on new commits.