Skip to content

feature/cp-11668-add-button-border-customization-for-in-app-banners-android#357

Open
unnaticleverpush wants to merge 2 commits into
masterfrom
feature/cp-11668-add-button-border-customization-for-in-app-banners-android
Open

feature/cp-11668-add-button-border-customization-for-in-app-banners-android#357
unnaticleverpush wants to merge 2 commits into
masterfrom
feature/cp-11668-add-button-border-customization-for-in-app-banners-android

Conversation

@unnaticleverpush

@unnaticleverpush unnaticleverpush commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Add configurable border (width, color, solid/dashed/dotted style) to banner buttons


Note

Low Risk
UI-only rendering and model parsing; default is no border when width is zero, with no auth or data-path changes.

Overview
Adds configurable button borders for in-app banner and inbox detail carousel buttons, driven by new JSON fields on button blocks.

BannerButtonBlock now reads borderWidth, borderColor, and borderStyle and exposes getters. Button backgrounds go through a new applyBorder helper in AppBannerCarouselAdapter and InboxDetailBannerCarouselAdapter: when width is ≤ 0, behavior stays unchanged (fill only). Otherwise borders use the block’s corner radius and PX scale; solid borders use GradientDrawable.setStroke, while dashed / dotted use a stacked LayerDrawable and software rendering on API 21+. Missing border color defaults to white.

Reviewed by Cursor Bugbot for commit 480d134. Bugbot is set up for automated code reviews on this repo. Configure here.


Summary by cubic

Adds configurable borders to Android in‑app banner buttons: width, color, and solid/dashed/dotted styles. Aligns with Linear CP‑11668 and keeps current look by default.

  • New Features
    • BannerButtonBlock: adds borderWidth, borderColor, borderStyle and parses them from JSON.
    • Button rendering: draws solid/dashed/dotted borders using GradientDrawable/LayerDrawable, respects corner radius and PX scale; dashed/dotted require Lollipop+ (fallback to solid) and force software layer; no border when width ≤ 0.
    • Applied in AppBannerCarouselAdapter and InboxDetailBannerCarouselAdapter; default border color is white when borderColor is missing.

Written for commit 480d134. Summary will update on new commits.

Review in cubic

…ndroid

Add configurable border (width, color, solid/dashed/dotted style) to banner buttons
@unnaticleverpush unnaticleverpush self-assigned this Jun 12, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f3f1475. Configure here.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 3 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant