chore(repo): Various release workflow fixes#8020
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| permissions: | ||
| contents: read | ||
| id-token: write | ||
| pull-requests: write |
There was a problem hiding this comment.
Needed so that GITHUB_TOKEN can react to !snapshot comments and write the response when the release finishes.
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
| result-encoding: string | ||
| retries: 3 | ||
| retry-exempt-status-codes: 400,401 | ||
| github-token: ${{ secrets.CLERK_COOKIE_PAT }} |
There was a problem hiding this comment.
GITHUB_TOKEN is the default value, no need to be explicit, see https://github.com/actions/github-script/tree/v7
| if: steps.version-packages.outputs.success == '1' | ||
| uses: peter-evans/create-or-update-comment@v3.0.0 | ||
| with: | ||
| token: ${{ secrets.CLERK_COOKIE_PAT }} |
There was a problem hiding this comment.
GITHUB_TOKEN is the default value, no need to be explicit, see https://github.com/peter-evans/create-or-update-comment/tree/v3.0.0
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe changes modify the GitHub release workflow by consolidating multiple workflow_dispatch calls into batched arrays handled with Promise.all in pre-release and canary-release flows. Workflow permissions have been expanded to include pull-requests: write access. npm commands have been replaced with pnpm equivalents for version management and build operations. PR fetching logic was updated to destructure response data. Authentication token references were removed from comment update and cleanup steps. A sourceCommit parameter was added to dispatch inputs. Conditional dispatch logic was introduced for canary-release flows, maintaining existing canary-specific conditional checks. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
nikosdouvlis
left a comment
There was a problem hiding this comment.
These all look good to me
Description
Following #7915 there were many small pre-existing things to fix. Now that we went through a whole release loop with the new workflow and everything works fine I packaged the fixes in here.
GITHUB_TOKENeverywhere possiblepnpminstead ofnpm/npxwhere relevantChecklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
Release Notes