-
Notifications
You must be signed in to change notification settings - Fork 436
feat(e2e): add next-app-router-bundled-ui integration template #7826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add a Next.js App Router integration template that uses `@clerk/ui` bundled UI
via `ui={ui}` on `<ClerkProvider>`. Includes sign-in, sign-up, user-button, and
theme test pages for dark, neobrutalism, shadesOfPurple, and shadcn themes.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 1971f44 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a new Next.js 15 App Router template 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. No actionable comments were generated in the recent review. 🎉 Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
🤖 Fix all issues with AI agents
In `@integration/presets/longRunningApps.ts`:
- Around line 39-43: The new long-running app entry
'next.appRouterBundledUI.withEmailCodes' (config: next.appRouterBundledUI) was
added but no tests were added; add integration tests that exercise the bundled
UI template's core flows (sign-up, sign-in, and theme switching) by creating new
test cases alongside the existing longRunningApps tests (or in the same test
suite used by other next.appRouter* entries) that instantiate the template ID
'next.appRouterBundledUI.withEmailCodes', perform a full sign-up + sign-in cycle
using email codes, and verify theme toggling persists/updates UI classes or
styles; ensure tests mirror the structure and assertions used for other
templates in this folder so CI covers the new flows before merge.
In `@integration/presets/next.ts`:
- Around line 39-53: The new preset variable appRouterBundledUI (created via
applicationConfig() and templates['next-app-router-bundled-ui']) lacks test
coverage; add integration tests that scaffold the template and assert key
pages/build/dev serve render correctly — e.g., a test that runs the template
generator for appRouterBundledUI, verifies expected files are created
(routes/pages, bundled UI assets) and that running the build/dev commands
(scripts 'build'/'dev' defined on the config) returns successful exit codes and
expected HTML content; place tests alongside other preset tests and follow
existing test helpers/assertions used for other presets to mirror patterns.
In `@integration/templates/next-app-router-bundled-ui/package.json`:
- Around line 12-17: The package.json pins "react" and "react-dom" to 18.3.1
which is incompatible with Next.js 15; update the dependency entries for "react"
and "react-dom" to React 19 (e.g., change their version strings to "^19.0.0" or
"19.x") so the template uses React 19 required by Next.js 15 App Router and
ensure no other packages conflict with React 19.
In `@integration/templates/next-app-router-bundled-ui/src/app/globals.css`:
- Around line 1-49: Update globals.css to satisfy Stylelint by converting legacy
rgba() usages to modern color-function notation (e.g. change rgba(1, 65, 255,
0.4) to rgb(1 65 255 / 0.4)) for --primary-glow and --secondary-glow, ensure any
hex colors and keywords (like transparent) are lowercase, convert any color
shorthand or alias forms that trigger color-function-notation/alias-notation
(e.g. replace `#16ABFF33` with lowercase `#16abff33` or use rgb(...) / alpha), add
or adjust blank lines before groups of custom properties in the :root blocks to
satisfy custom-property-empty-line-before, and ensure value keywords follow
lowercase value-keyword-case so variables like --foreground-rgb,
--background-start-rgb, --tile-border, and --card-border-rgb conform to the
linter.
Test sign-in, sign-up, user-button, sign-out, and theme rendering against the next-app-router-bundled-ui long-running app.
Summary
next-app-router-bundled-uiintegration template that imports@clerk/uiand passesui={ui}to<ClerkProvider>dark,neobrutalism,shadesOfPurple, andshadcnthemes@clerk/uidependency), and long-running app entryTest plan
pnpm buildpassesSummary by CodeRabbit