-
Notifications
You must be signed in to change notification settings - Fork 431
feat(clerk-js): remove headless variant #7629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jacekradko
wants to merge
57
commits into
main
Choose a base branch
from
jrad/remove-headless-variant
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
2e52e40
feat(nextjs): skip clerk-ui script injection for headless variant
nikosdouvlis 6ab9de3
feat(astro): skip clerk-ui script injection for headless variant
nikosdouvlis 9a82f92
feat(react): skip clerk-ui loading for headless variant
nikosdouvlis d5f819a
feat(vue): skip clerk-ui loading for headless variant
nikosdouvlis a2e16cd
test(e2e): add headless variant test for nextjs
nikosdouvlis 9d3bbe6
Merge branch 'main' into nikos/dont-load-clerk-ui-if-headless-is-used
nikosdouvlis f643280
dedupe
nikosdouvlis 320bdde
feat(clerk-js): remove headless variant, use react-native export cond…
jacekradko 92fe11c
Merge branch 'nikos/dont-load-clerk-ui-if-headless-is-used' of github…
jacekradko bb62787
fix: un-deprecate clerkJSVariant, update docs
jacekradko bc48c7e
feat: rename clerkJSVariant to ui prop for controlling UI script loading
jacekradko 84c2552
Merge branch 'main' into jrad/remove-headless-variant
jacekradko 1ca99cb
fix: update integration templates and tests to use ui prop
jacekradko eee7409
fix: update expo and chrome-extension for headless removal
jacekradko b85a057
fix: restore /no-rhc export for chrome-extension CSP compliance
jacekradko f3a8681
fix: add false-cjs to attw ignore rules for exports field
jacekradko a608376
feat: rename ui prop to prefetchUI for disabling UI bundle prefetching
jacekradko 7c3fb9a
fix: update nuxt and tanstack-react-start for prefetchUI rename
jacekradko ff90124
format
jacekradko a0068a4
fix: update ClerkProvider type tests for prefetchUI prop rename
jacekradko 40b99fd
fix: align env schema variable name with usage (PUBLIC_CLERK_PREFETCH…
jacekradko b28c7be
Merge branch 'main' into jrad/remove-headless-variant
jacekradko e67dfa5
fix: add shouldPrefetchClerkUi to mock in isomorphicClerk test
jacekradko 7bb210f
Merge branch 'main' into jrad/remove-headless-variant
jacekradko 06ca9e7
chore(clerk-js): remove obsolete headless test
jacekradko 4120be2
chore(clerk-js): remove headless references from config files
jacekradko 54ac826
wip
jacekradko a1416d6
fix: restore clerkUiUrl env support for integration tests
jacekradko cda44df
fix: restore clerkUiUrl in public types
jacekradko 60e5732
chore: rename headless-variant test to prefetch-ui
jacekradko 3ef7871
fix: update nextjs type tests for new prefetchUI API
jacekradko 11e3189
fix: pass clerkUiUrl to ClerkScripts opts
jacekradko 192a776
fix: pass clerkUiUrl through astro and react-router
jacekradko 16453c1
fix: rename clerkUiUrl to clerkUIUrl for consistency with clerkJSUrl
jacekradko 1719aea
fix: rename clerkUiUrl to clerkUIUrl in integration templates
jacekradko 05b569c
Merge branch 'main' into jrad/remove-headless-variant
jacekradko af03b1a
Merge branch 'main' into jrad/remove-headless-variant
jacekradko 230f108
feat(upgrade): add codemod and change files for clerkJSVariant removal
jacekradko 32e7dfe
chore: trigger CI
jacekradko 2c7f5e4
fix: format upgrade package
jacekradko 732a375
Merge branch 'main' into jrad/remove-headless-variant
jacekradko d21694e
fix: wait for Clerk to load before signOut in components test
jacekradko 27ed28a
fix: use inline expression for prefetchUI to match existing code style
jacekradko a708fb2
fix: restore clerkUIUrl in express loadClientEnv
jacekradko c962cca
fix: rename shouldPrefetchClerkUi to shouldPrefetchClerkUI for consis…
jacekradko 9452d48
fix: remove unnecessary 'as any' casts in ReactRouterClerkProvider
jacekradko 10f6b15
fix: use inline expression for prefetchUI in react-router env.ts
jacekradko be5c39c
fix: rename ClerkUi to ClerkUI for consistency in script loading func…
jacekradko 3c5f8db
chore: remove unnecessary clerk-ui-url-renamed upgrade doc
jacekradko 4857764
docs: add codemod note to clerkJSVariant removal upgrade doc
jacekradko 3d619df
docs: simplify codemod note in upgrade doc
jacekradko b295696
fix: remove clerkUiUrl codemod since prop was never released
jacekradko 4bb635b
chore: remove clerkUiUrl rename from changeset
jacekradko ed4defd
feat: add ClerkJS aliases with deprecated ClerkJs versions
jacekradko 3dbc51e
docs: clarify prefetchUI behavior in upgrade doc
jacekradko ed7e49b
feat: improve API consistency and fix clerkUIVersion
jacekradko c2824b6
fix: type errors in isomorphicClerk.ts
jacekradko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| '@clerk/clerk-js': major | ||
| '@clerk/shared': major | ||
| '@clerk/react': minor | ||
| '@clerk/nextjs': minor | ||
| '@clerk/astro': minor | ||
| '@clerk/nuxt': minor | ||
| '@clerk/vue': minor | ||
| '@clerk/react-router': minor | ||
| '@clerk/tanstack-react-start': minor | ||
| '@clerk/expo': minor | ||
| '@clerk/chrome-extension': minor | ||
| --- | ||
|
|
||
| Remove `clerkJSVariant` option and headless bundle. Use `prefetchUI={false}` instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import { expect, test } from '@playwright/test'; | ||
|
|
||
| import type { Application } from '../models/application'; | ||
| import { appConfigs } from '../presets'; | ||
|
|
||
| test.describe('prefetchUI disabled @nextjs', () => { | ||
| test.describe.configure({ mode: 'serial' }); | ||
| let app: Application; | ||
|
|
||
| test.beforeAll(async () => { | ||
| app = await appConfigs.next.appRouter.clone().commit(); | ||
| await app.setup(); | ||
| // Use withEmailCodes but disable the UI prefetching | ||
| const env = appConfigs.envs.withEmailCodes.clone().setEnvVariable('public', 'CLERK_PREFETCH_UI_DISABLED', 'true'); | ||
| await app.withEnv(env); | ||
| await app.dev(); | ||
| }); | ||
|
|
||
| test.afterAll(async () => { | ||
| await app.teardown(); | ||
| }); | ||
|
|
||
| test('does not inject clerk-ui script when prefetchUI is disabled', async ({ page }) => { | ||
| await page.goto(app.serverUrl); | ||
|
|
||
| // Wait for clerk-js script to be present (ensures page has loaded) | ||
| await expect(page.locator('script[data-clerk-js-script]')).toBeAttached(); | ||
|
|
||
| // clerk-ui script should NOT be present | ||
| await expect(page.locator('script[data-clerk-ui-script]')).not.toBeAttached(); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.