Skip to content

Stop emitting explicit version in Homebrew formulae - #402

Merged
rafa-thayto merged 1 commit into
mainfrom
fix/homebrew-redundant-version
Jul 30, 2026
Merged

Stop emitting explicit version in Homebrew formulae#402
rafa-thayto merged 1 commit into
mainfrom
fix/homebrew-redundant-version

Conversation

@rafa-thayto

@rafa-thayto rafa-thayto commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

The homebrew-stable tap's CI went red on this run: brew audit now fails every formula with version X.Y.Z is redundant with version scanned from URL.

Root cause is Homebrew/brew#23338 (merged Jul 28): brew now prefers the numeric release tag (v2.3.1) in /releases/download/vX.Y.Z/… URLs over the asset filename when scanning versions, so it derives the version on its own and treats our explicit version line as a redundancy error.

clerk/homebrew-stable#3 fixes the four already-published formulae; this PR fixes the generator (renderFormula in scripts/lib/homebrew.ts) so the next release doesn't reintroduce the line.

The formula's test do block keeps working: version.to_s resolves from the URL-scanned version.

Validation

  • bun test scripts/lib/homebrew.test.ts — 11 pass
  • bun run format / bun run lint — clean
  • bun run typecheck — clean (an earlier failure in cli-core's integration harness test was stale local node_modules; passes after bun install --frozen-lockfile)
  • The equivalent formula change (version line removed) passes brew audit --except=installed --tap=clerk/stable, brew style, and brew readall locally on brew ed35dbcb2e — the exact commit the failing CI run used — and versions scan correctly (2.3.1 / 0.8.4 / 1.5.0 / 2.3.1)

No changeset: release tooling only, no user-facing CLI behavior change.

Homebrew/brew#23338 (merged 2026-07-28) made brew prefer the numeric
release tag over asset filenames when scanning versions from URLs, so
brew now derives the version from the /releases/download/vX.Y.Z/ path
and flags explicit version lines as redundant, failing brew audit in
the homebrew-stable tap's CI (clerk/homebrew-stable#3 fixed the
already-published formulae).
@changeset-bot

changeset-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4b4cd97

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Homebrew formula generation no longer includes an explicit version line. The existing conditional keg_only :versioned_formula output remains attached to the license line, and the rendering test now verifies that no version declaration is emitted.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: removing explicit version emission from Homebrew formulae.
Description check ✅ Passed The description is directly related and explains the generator change, cause, and validation steps.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rafa-thayto
rafa-thayto enabled auto-merge (squash) July 30, 2026 17:04
@rafa-thayto
rafa-thayto merged commit 8d82754 into main Jul 30, 2026
11 checks passed
@rafa-thayto
rafa-thayto deleted the fix/homebrew-redundant-version branch July 30, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants