[pre-commit.ci] pre-commit autoupdate - #49
Conversation
updates: - [github.com/astral-sh/ruff-pre-commit: v0.16.1 → v0.16.2](astral-sh/ruff-pre-commit@v0.16.1...v0.16.2) - [github.com/facebook/pyrefly-pre-commit: 1.2.0 → 1.3.0.dev1](facebook/pyrefly-pre-commit@1.2.0...1.3.0.dev1) - [github.com/rvben/rumdl-pre-commit: v0.2.49 → v0.2.53](rvben/rumdl-pre-commit@v0.2.49...v0.2.53) - [github.com/astral-sh/ty-pre-commit: v0.0.65 → v0.0.69](astral-sh/ty-pre-commit@v0.0.65...v0.0.69)
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the versions of several pre-commit hooks (ruff, pyrefly, rumdl, ty) in .pre-commit-config.yaml to their newer releases, without changing hook configuration or adding/removing hooks. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
No application code in the PR — skipped Code Health checks.
See analysis details in CodeScene
Quality Gate Profile: Customizable Safeguards
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The pyrefly hook is now pinned to a dev release (
1.3.0.dev1); consider whether you really want to track a dev version here or prefer a stable tag to avoid unexpected behavior changes from pre-release updates.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The pyrefly hook is now pinned to a dev release (`1.3.0.dev1`); consider whether you really want to track a dev version here or prefer a stable tag to avoid unexpected behavior changes from pre-release updates.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #49 +/- ##
========================================
Coverage 99.69% 99.69%
========================================
Files 23 23
Lines 3301 3301
========================================
Hits 3291 3291
Misses 10 10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
LlamaPReview — No blocking issues found
Safe to merge: four dev hook pins are bumped, all current-head CI (including pre-commit) is green, and user-facing presets are untouched.
2 non-blocking findings retained — highest: Repository's own type check now uses a prerelease tag.
Review details and evidence
| Priority | File | Finding | Evidence |
|---|---|---|---|
| P2 | lang/py/preset.yaml |
User-facing py preset still pins older ruff and pyrefly revisions | confirmed |
| P2 | .pre-commit-config.yaml |
Repository's own type check now uses a prerelease tag | confirmed |
Finding details
P2 · User-facing py preset still pins older ruff and pyrefly revisions
lang/py/preset.yaml
The root .pre-commit-config.yaml moves to ruff v0.16.2 and pyrefly 1.3.0.dev1, but the shipped py preset at lang/py/preset.yaml still pins the older revisions. This PR does not update generated user configs, so user output is unchanged. If mirroring the root config is intended, a follow-up should bump the preset pins or automate syncing.
Owner action: Consider a follow-up to bump lang/py/preset.yaml to match the new hook revisions if the mirroring is intended.
Verification boundary: confirmed; scope: bounded reviewed context.
Material unknowns
- Upstream release notes for the four new hook revisions were not independently inspected. Without them, the green pre-commit CI run at head already validates the new revisions against this repository, so the merge decision is unaffected.
- Check: No action required for merge; optional curiosity check on upstream notes.
LlamaPReview checks
- Inspected matching PR-head repository snippets in
.claude/docs/adr/0001-hook-profile-categories.md,.pre-commit-config.yaml,lang/py/preset.yaml. - Inspected matching PR-head repository snippets in
lang/py/preset.yaml. - Read bounded PR-head context from
.pre-commit-config.yaml.
Automated review by LlamaPReview · Free for public open-source projects.
| - repo: https://github.com/facebook/pyrefly-pre-commit | ||
| rev: 1.2.0 | ||
| rev: 1.3.0.dev1 | ||
| hooks: | ||
| - id: pyrefly-check |
There was a problem hiding this comment.
P2 | Confidence: Medium
The pyrefly-pre-commit hook is bumped to the development tag 1.3.0.dev1. Exact-head CI passes with it, and no repository policy requires stable tags. The residual risk is future churn or instability in the repository's own type checks if upstream dev releases regress. Maintainers preferring stable pins can switch back in a follow-up.
Owner action: Optionally switch pyrefly-pre-commit back to a stable release in a follow-up if stable pins are preferred.
Evidence: bounded PR-head context from .pre-commit-config.yaml.
updates:
Summary by Sourcery
Update pre-commit hook versions to use newer releases of existing linters and formatters.
Build: