Handle large json failures#666
Merged
JamieMagee merged 3 commits intoclearlydefined:masterfrom Jan 30, 2026
Merged
Conversation
jeffmendoza
approved these changes
Jan 7, 2026
Contributor
|
@pombredanne the merge is blocked by a scancode error |
eda3234 to
c450982
Compare
The PR added this.logger.error() calls but the test mocks only had log and info methods. Also fixed prettier formatting.
Contributor
|
The tests were failing because the new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The output files for particularly large or complex repositories can be quite large which can lead to errors like this one:
But we don't want that error to obscure the underlying exceptions, so I suggest that we first always log, and then add an extra level of try-catch in _hasRealErrors.