Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for plotting additional observation variables (pressure, temperature, relative humidity) in vertical profile analyses, along with a new feature to load experiments from external URLs.
Key changes:
- Extended
observationsForProfile()to support pressure, temperature, and relative humidity variables - Added URL-based experiment loading via the
?e=query parameter - Improved toast UX for promise-based operations with persistent error toasts
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
apps/class-solid/src/lib/profiles.ts |
Added support for rh, T, and p variables in observation profiles; fixed template literal syntax in warning message |
apps/class-solid/src/lib/state.ts |
Implemented loadExperimentFromUrl() function to fetch and load experiments from external URLs via ?e= query parameter |
apps/class-solid/src/components/ui/toast.tsx |
Made error toasts persistent and added close button to rejected state for better error handling UX |
apps/class-solid/README.md |
Added comprehensive documentation for loading experiments from URLs, including local development setup example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Peter9192
approved these changes
Nov 24, 2025
Member
Peter9192
left a comment
There was a problem hiding this comment.
This also works well. One side note is that if we want to add other variables we might need to extend the interface and schema here:
class-web/apps/class-solid/src/lib/experiment_config.ts
Lines 11 to 19 in 7da9999
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #184
To test use test setup from #187 and in vertical plot analyse select