feat(graphics/rdr3): improve ERR_GFX_STATE error messages#3761
Closed
Ehbw wants to merge 1 commit intocitizenfx:masterfrom
Closed
feat(graphics/rdr3): improve ERR_GFX_STATE error messages#3761Ehbw wants to merge 1 commit intocitizenfx:masterfrom
Ehbw wants to merge 1 commit intocitizenfx:masterfrom
Conversation
Currently in RedM users encountering ERR_GFX_STATE aren't provided any meaningful details to help troubleshoot this crash. This crash can occur for hundreds of reasons across both graphics drivers. This patch aims to resolve that by removing hundreds of instances of ERR_GFX_STATE and replacing them with proper information from the Graphics driver being actively used. There is one function left in the vulkan graphics driver that can call ERR_GFX_STATE this is because there isn't enough information in what calls this and why at this moment in time.
github-actions
Bot
added
RedM
Contributor
Author
|
The functionality of this PR has been merged into a more complete graphics patch fixing various Vulkan startup crashes and using this patch to properly handle pipeline cache invalidation. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Remove ~200 instances of ERR_GFX_STATE errors that users hit, instead replacing them with more meaningful and verbose error messages that can help with troubleshooting the issue. This also improves crash metrics for server owners, allowing better monitoring of graphical crashes potentially in relation to new/changed contents.
How is this PR achieving the goal
Backport from some of my own work on updating cef and redm game-view.
Replacing three calls that act as D3D12 Failed macro, Vulkan VK_ERROR_DEVICE_LOST check and Vulkan swapchain creation error checking that when receiving an non success code, will throw the ERR_GFX_STATE error. These are then replaced with more in-depth errors based on the dxerr library return results and VkResult information.
This PR applies to the following area(s)
RedM
Successfully tested on
Game builds: 1491
Platforms: Windows, Linux
Checklist
Fixes issues