Respect the direction set in a template stream#618
Open
bifurcation wants to merge 1 commit intocisco:mainfrom
Open
Respect the direction set in a template stream#618bifurcation wants to merge 1 commit intocisco:mainfrom
bifurcation wants to merge 1 commit intocisco:mainfrom
Conversation
Member
|
This code apears to be 17 years old and kind of unchanged, I agree that it should be fixed, but it might break things for exisitng clients if they have been doing it wrong. Maybe this is something for 3.0 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix the logical error noted in #617, that the directions set on a template stream are not checked when the template stream is used to create new (directed) streams. It simply adds checks in
srtp_protect_mkiandsrtp_unprotect_mkithat verify that the template stream's direction is compatible with the context, either the same direction ordir_srtp_unknown. Marking as WIP because even if we agree on approach, we probably need to cover the analgous RTCP methods.Note that there is compatibility risk in merging this PR: If there are consumers that are relying the ambiguity noted here, then they will fail.