Skip to content

fix: propagate cumulative gas overflow in block executor (#42 follow-up) #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crazywriter1 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

fix: propagate cumulative gas overflow in block executor (#42 follow-up) #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/evm/src/executor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ use revm::DatabaseCommit;
const ERR_BLOCKLIST_READ_FAILED: &str = "Failed to read beneficiary blocklist status";
const ERR_BLOCK_NUMBER_CONVERSION_FAILED: &str = "Failed to convert block number to u64";
const ERR_BLOCK_TIMESTAMP_CONVERSION_FAILED: &str = "Failed to convert block timestamp to u64";
const ERR_CUMULATIVE_GAS_OVERFLOW: &str = "cumulative gas overflow while executing block";

/// Result of executing an Arc transaction.
#[derive(Debug)]
Expand Down Expand Up @@ -456,7 +457,7 @@ where
self.gas_used = self
.gas_used
.checked_add(gas_used)
.expect("cumulative gas overflow");
.ok_or_else(|| BlockExecutionError::msg(ERR_CUMULATIVE_GAS_OVERFLOW))?;

// Cancun is always active for arc
self.blob_gas_used = self.blob_gas_used.saturating_add(blob_gas_used);
Expand Down