metrics: clean up policy metrics when tracing policies are deleted#4500
Open
gr3chk wants to merge 1 commit intocilium:mainfrom
Open
metrics: clean up policy metrics when tracing policies are deleted#4500gr3chk wants to merge 1 commit intocilium:mainfrom
gr3chk wants to merge 1 commit intocilium:mainfrom
Conversation
Policy-labeled metric series are currently kept after a TracingPolicy is deleted, which can cause stale metrics to remain exported. Register tracing-policy metrics for cleanup and removes their series from the registry when a policy is deleted, regardless of how the policy was created or removed. Fixes: cilium#2256 Signed-off-by: David Grechkin <gr3chkin@gmail.com>
kkourt
added
the
needs-rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Policy-labeled metric series are currently kept after a TracingPolicy is deleted, which can cause stale metrics to remain exported.
Register tracing-policy metrics for cleanup and removes their series from the registry when a policy is deleted, regardless of how the policy was created or removed.
Fixes: #2256
Description
Ensure policy-labeled metric series are properly cleaned up when a TracingPolicy is deleted, preventing stale metrics from remaining exported.
Changelog