Skip to content

chore: replace absl::optional/nullopt with std equivalents#1940

Open
0xch4z wants to merge 1 commit into
cilium:mainfrom
0xch4z:pr/ck/absl-optional-cleanup
Open

chore: replace absl::optional/nullopt with std equivalents#1940
0xch4z wants to merge 1 commit into
cilium:mainfrom
0xch4z:pr/ck/absl-optional-cleanup

Conversation

@0xch4z

@0xch4z 0xch4z commented Jun 5, 2026

Copy link
Copy Markdown
Member

Replaces deprecated absl::optional, absl::nullopt with std::optional and std::nullopt.

@0xch4z 0xch4z requested a review from a team as a code owner June 5, 2026 16:24
@0xch4z 0xch4z requested a review from jrajahalme June 5, 2026 16:24
Replaces deprecated absl::optional, absl::nullopt with std::optional and
std::nullopt.

Signed-off-by: Charlie Kenney <charles.kenney@isovalent.com>
@0xch4z 0xch4z force-pushed the pr/ck/absl-optional-cleanup branch from af90368 to 4f58806 Compare June 5, 2026 16:26

@sayboras sayboras left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While absl::optional could be deprecated, we might need to wait/propose changes in upstream first

https://github.com/envoyproxy/envoy/blob/9297c23ebfdc5ca2171873261d01a7d65ff75b32/tools/code_format/check_format.py#L691-L692

@sayboras sayboras added the dont-merge/preview-only DON'T MERGE label Jun 8, 2026
@nezdolik nezdolik self-assigned this Jun 12, 2026
@nezdolik

Copy link
Copy Markdown
Contributor

i will check if anyone in upstream is working on this already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants