Skip to content

ci(tests) Verify runtime deps#325

Open
tony wants to merge 1 commit intomasterfrom
ci-test-runtime-deps
Open

ci(tests) Verify runtime deps#325
tony wants to merge 1 commit intomasterfrom
ci-test-runtime-deps

Conversation

@tony
Copy link
Copy Markdown
Member

@tony tony commented Feb 20, 2025

Changes

  • Add runtime dependency check in CI using uv run --no-dev
  • Run check before installing dev dependencies
  • Print package version and basic functionality test results
  • Document improvement in CHANGES

Summary by Sourcery

Enhance the CI workflow by adding a runtime dependency check to ensure all necessary packages are available before installing development dependencies, and document this improvement.

CI:

  • Add a step in the CI workflow to verify runtime dependencies using uv run --no-dev before installing development dependencies.

Documentation:

  • Document the improvement in the CHANGES file.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Feb 20, 2025

Reviewer's Guide by Sourcery

This pull request introduces a runtime dependency check in the CI workflow to ensure that the application can run with only its runtime dependencies, without the development dependencies. It also includes a basic functionality test and documentation updates.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Add runtime dependency check in CI workflow.
  • Introduced a new step in the CI workflow to test runtime dependencies using uv run --no-dev.
  • The check is executed before installing development dependencies.
  • A basic functionality test is performed by printing the package version.
.github/workflows/tests.yml
Document the improvement in the change log.
  • Updated the CHANGES document to reflect the addition of the runtime dependency check.
CHANGES

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tony - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant