Validation fixes: build config, CI workflow, Eclipse config, server.xml, README#12
Merged
Conversation
…lugin to build/plugins, remove duplicate dependencyManagement from app module, simplify finalName
…; add foojay toolchain resolver to settings.gradle
… to match standard template
…0, messaging-3.1 for Spring Boot 3.x / Jakarta EE 10
…eanup-old-runs workflow; capitalise job name
…gin deployment option; update MAINTAINERS review date
…me to match pom.xml finalName
…) for app and cicsbundle modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deep validation pass against the CICSdev sample repository standards. Both Gradle and Maven builds pass locally against Java 17, 21, and 25.
Changes
Maven wrapper
maven-wrapper.jar(covered by.gitignoreper standards)Maven POM structure
groupIdfromcom.ibm.cicsdev→com.ibm.cicsdev.springbootacross root, app, and cicsbundle POMsmaven-compiler-pluginwith<release>into<build><plugins>in root POM (matches standard template)<dependencyManagement>block from app module (already declared in parent)<properties>from app module (all inherited from parent)finalNamein app module (removed${project.version}suffix)Gradle configuration
gradle.properties: added JDK auto-provisioning properties andconfiguration-cachedisabled commentsettings.gradle: added foojay toolchain resolver plugin for automatic JDK downloadEclipse configuration
.classpath: replaced with minimal form (JRE container + output only) — root is a parent POM, not a source module.settings/org.eclipse.jdt.core.prefs: added missingenablePreviewFeaturesandrelease=enabledsettings; removed excess debug/timestamp lines.settings/org.eclipse.core.resources.prefs: removed spuriousencoding//src/test/javaentryLiberty server.xml
servlet-3.1→servlet-6.0,concurrent-1.0→concurrent-3.0,jms-2.0→messaging-3.1CI/CD workflows
build.yaml:build-gradlewjob now uses onlysetup-java(notsetup-gradle) — validates wrapper works standalone; capitalised job namecleanup-old-runs.yamlworkflow (weekly housekeeping of old Actions runs)Documentation
README.md: corrected CICS TS prerequisite from V5.5 → V6.1+ (required for Spring Boot 3.x + Jakarta EE 10); added CICS bundle plugin ZIP deployment as deployment option 1MAINTAINERS.md: updated last reviewed date to July 2026