Restructure to multi-module project (app + cicsbundle)#10
Merged
Conversation
- Create cics-java-liberty-springboot-jms-app module
- Create cics-java-liberty-springboot-jms-cicsbundle module
- Move src/ to app module
- Move build.gradle and pom.xml to app module
- Create new root pom.xml with <packaging>pom</packaging>
- Update root settings.gradle with module includes
- Update app module pom.xml to inherit from parent
- Add Maven finalName to app module
- Add CICS Bundle Plugin 1.0.8 to cicsbundle module
- Add bootWar { enabled = false } to app build.gradle
- Add WAR archiveFileName configuration to app build.gradle
✅ Tested: Gradle build successful
✅ Tested: Maven build successful
- Update prerequisites: Java 17+, Spring Boot 3.x - Update CICS BOM reference to 6.1-20250812133513-PH63856 - Update build commands: 'clean build' for Gradle, 'clean verify' for Maven - Update servlet feature to servlet-6.0 (Jakarta EE 10) - Update messaging features for Jakarta EE 10 - Update artifact paths to reflect multi-module structure - Update artifact names to cics-java-liberty-springboot-jms-app-1.0.0 - Update deployment instructions with new module paths
Add ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION environment variable to check-copyright job to suppress Node 20 deprecation warning from the cicsdev copyright checker action. Reference: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Change from ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION to FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 as recommended by GitHub. This forces all JavaScript actions to run on Node.js 24 instead of the deprecated Node.js 20. Reference: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Change permissions from 'contents: read' to 'contents: write' and 'pull-requests: write' to allow the copyright checker action and create-pull-request action to function properly. This fixes the 'git failed with exit code 128' error.
|
|
||
| permissions: | ||
| contents: read | ||
| contents: write |
Contributor
There was a problem hiding this comment.
Why write permission?
Change permissions back to 'contents: read' to align with other CICS sample repositories. The peter-evans/create-pull-request action was added automatically by GitHub Actions bot and is not part of the standard CICS sample workflow. The copyright checker works correctly with read-only permissions.
IvanHargreaves
requested changes
Jun 29, 2026
| runs-on: ubuntu-latest | ||
| name: Check Copyright | ||
| env: | ||
| FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true |
Contributor
There was a problem hiding this comment.
What does this new line do?
- Move write permissions from workflow level to job level - Only check-copyright job gets contents:write and pull-requests:write - Other jobs inherit workflow-level contents:read (secure by default) - Remove FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 (only addresses warning) This is the correct approach for the copyright checker that creates PRs while keeping other jobs with minimal permissions.
IvanHargreaves
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.