Springboot Version update by Manvi-55 · Pull Request #16 · cicsdev/cics-java-liberty-springboot-jcics

Manvi-55 · 2026-01-07T07:46:43Z

No description provided.

IvanHargreaves · 2026-01-07T15:35:36Z

build.gradle

@@ -1,7 +1,7 @@
-plugins
+/*plugins


This whole comment out section should be removed.

sure,I have removed this whole comment out section.

IvanHargreaves · 2026-01-07T15:36:31Z

build.gradle

+    //*/
+ plugins
+{
+    id 'org.springframework.boot' version '3.3.5'


A higher stable version is available, we should move to that.

sure,I have updated the version.

IvanHargreaves · 2026-01-07T15:37:02Z

build.gradle

+    sourceCompatibility = JavaVersion.VERSION_17
+    targetCompatibility = JavaVersion.VERSION_17
+}
+//java


Clean-up and remove all old comments please.

Done. I’ve cleaned up and removed all old comments.

IvanHargreaves · 2026-01-07T15:37:40Z

build.gradle

+    //    url "https://public.dhe.ibm.com/ibmdl/export/pub/software/websphere/maven/repository/"
+    //}
+}
+dependencies {


Remove commented out libraries, and add good comments to each library that is used.

sure,I’ve removed the commented-out libraries and added appropriate comments for each library that is used.

IvanHargreaves · 2026-01-07T15:38:28Z

build.gradle

+    // Not needed
+    //implementation("org.springframework.boot:spring-boot-starter-actuator")
+    // Use correct BOM version for CICS TS
+    compileOnly(enforcedPlatform("com.ibm.cics:com.ibm.cics.ts.bom:6.2-20250528120756-PH65227"))


We should level-set on CICS TS V6.1 as our min CICS release - add a comment to suggest users can move to a higher level of BOM to match their target CICS region.

Done,I've updated the cics bom version to 6.1 and added a comment for users for the same as well.

IvanHargreaves · 2026-01-07T15:41:26Z

build.gradle

+//{
+//    enabled = false // disable plain WAR, use bootWar instead
+//}
+publishing {


I'm not clear on why this section has changed from the original?

IvanHargreaves · 2026-01-07T15:42:18Z

pom.xml

    <groupId>org.springframework.boot</groupId>
    <artifactId>spring-boot-starter-parent</artifactId>
-    <version>2.7.0</version>
+    <version>3.3.5</version>


Version need updating.

pom.xml

IvanHargreaves · 2026-01-07T15:43:29Z

pom.xml

      <groupId>org.springframework.boot</groupId>
      <artifactId>spring-boot-starter-web</artifactId>
    </dependency>
+    <dependency>


This dependency has been separated from it's comment above and needs to be matched back up.

Thanks for pointing this out — I’ve moved the comment so it now correctly matches the dependency.

src/main/java/com/ibm/cicsdev/springboot/jcics/Application.java

IvanHargreaves · 2026-01-07T15:44:40Z

src/main/java/com/ibm/cicsdev/springboot/jcics/Application.java

-	{
-		SpringApplication.run(Application.class, args);
-	}
+public class Application {


brackets should be CICS style, and not end-of-line.

IvanHargreaves

Hi Manvi. I've made various comments on the PR, hopefully you can work your way through them asking questions and learning about the types of rigour and best-practice we apply to the samples.

Manvi-55 · 2026-01-27T20:30:16Z

Hey Ivan, I’ve worked through your comments and tried my best to address and fix them. Thankyou, and please let me know if any further corrections are needed.

IvanHargreaves

A few more things to tweak.

IvanHargreaves · 2026-01-28T18:41:31Z

.classpath

 	</classpathentry>
-	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.8/"/>
-	<classpathentry kind="output" path="bin/default"/>
+	<classpathentry excluding="**" kind="src" output="target/classes" path="src/main/resources">


A lot of this added configuration is Maven-centric, the intention of the samples was to avoid making it specific to Maven or Gradle, so I think we have to remove a lot of this. The instructions in the README cover how to make it Maven, or Gradle specific after it's cloned to the users workspace.

sure,I have changed the classpath,please have a look into it.

build.gradle

IvanHargreaves · 2026-01-28T18:44:33Z

build.gradle

+    // JCICS API (version inherited from BOM)
+    compileOnly("com.ibm.cics:com.ibm.cics.server")
+    // Jakarta EE servlet API
+    compileOnly("jakarta.servlet:jakarta.servlet-api:6.0.0")


I forget now, but did we need to add this servlet dependency? There wasn't there one before this change so I'm just double checking.

Yeah,I did my mistake,I just checked that its not there in pom.xml.I tested the sample again by building and deploying it, and verified that the endpoints are working fine without it.

IvanHargreaves · 2026-01-28T18:45:20Z

build.gradle

+group = 'com.ibm.cicsdev.springboot'
+archivesBaseName='cics-java-liberty-springboot-jcics'
+version = '0.1.0'
+// No longer relevant


Please delete the code that's no longer relevant, rather than comment it out.

build.gradle

IvanHargreaves · 2026-01-28T18:47:49Z

pom.xml

  </properties>

-  <!-- CICS TS V5.5 BOM (as of May 2020) -->
+  <!-- CICS TS V6.1 BOM (as of May 2020) -->


May 2020 is not the correct date for the V6.1 BOM. The version string suggests Sept 2024 is the matching date.

sorry,missed that,edited.

manvisingh55 and others added 3 commits November 12, 2025 13:26

Added code

fffbf8f

Initial commit

c07e0b8

Delete .DS_Store

d153c8f

IvanHargreaves reviewed Jan 7, 2026

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

IvanHargreaves reviewed Jan 7, 2026

View reviewed changes

src/main/java/com/ibm/cicsdev/springboot/jcics/Application.java Show resolved Hide resolved

IvanHargreaves reviewed Jan 7, 2026

View reviewed changes

IvanHargreaves requested changes Jan 7, 2026

View reviewed changes

this is the edited commit after comments on previous one

fc96135

IvanHargreaves requested changes Jan 28, 2026

View reviewed changes

IvanHargreaves requested review from IvanHargreaves and PhilWakelin January 28, 2026 18:49

manvisingh55 added 2 commits January 29, 2026 19:11

2nd round of changes

aa2b2bb

refreshed commit

5fbb17e

IvanHargreaves approved these changes Jan 30, 2026

View reviewed changes

IvanHargreaves merged commit 4c90d9c into cicsdev:main Feb 3, 2026

Conversation

Manvi-55 commented Jan 7, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

IvanHargreaves left a comment

Choose a reason for hiding this comment

Uh oh!

Manvi-55 commented Jan 27, 2026

Uh oh!

IvanHargreaves left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants