Merged
Conversation
heathhenley
force-pushed
the
dev_hh_toggle_nerd_font
branch
from
0bdd95d to
3d1957d
Compare
chshersh
added
type: feature
chshersh
approved these changes
Jul 31, 2025
Owner
chshersh
left a comment
chshersh
left a comment
There was a problem hiding this comment.
This is actually a high quality contribution.
So I'm approving it to merge it. I don't want to have a hanging PR 😅
I'm not actively working on this project rn but I still want to finish it someday. This change is needed, so I'd love to accept it and maybe I'll be able to come back one day.
Collaborator
Author
|
Nice! I hope to continue to contribute here and there too, it's a fun project! I noticed you've switched to C++ based on your socials - welcome and I'm sorry 🤣 |
Owner
|
Time to rewrite this project to C++ 😅 Nah, I'm joking. Unless... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There must be better way than this - but it's all I could come up with without using anything mutable (eg a ref in in the Icons module we could toggle at start).
What do you think - did I miss something silly?