fix(eventdismiss): dismiss lamp award dialogue; rename to Random Event Handler#474
Open
runsonmypc wants to merge 1 commit into
Open
fix(eventdismiss): dismiss lamp award dialogue; rename to Random Event Handler#474runsonmypc wants to merge 1 commit into
runsonmypc wants to merge 1 commit into
Conversation
…ases After confirming a skill on a lamp, the XP-award "Click here to continue" dialogue was left open, so the lamp was never consumed. UseLampEvent then kept re-queuing and the BlockingEventManager pause gate never released, freezing other plugins. Dismiss the continue dialogue (bounded waits) before checking consumption so the event clears and scripts resume cleanly. Also rename the plugin display name and overlay title to "Random Event Handler" (config group key left unchanged to preserve user settings) and bump version to 2.1.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LampUtility.useLamp()leaving the post-confirm "Click here to continue" XP-award dialogue open. The lamp was never consumed, so theUseLampEventblocking event re-queued indefinitely and theBlockingEventManagerscript-pause gate never released — freezing every other running plugin. The continue dialogue is now dismissed (bounded waits) before checking consumption, so the event clears and scripts resume cleanly.@PluginDescriptor) and overlay title to Random Event Handler. The@ConfigGroup("EventDismiss")storage key is intentionally unchanged to preserve existing user settings.2.1.0→2.1.1.Test plan
./gradlew build -PpluginList=EventDismissPlugin— compiles, producesEventDismissPlugin-2.1.1.jar.