Support persistent & binary queries/callbacks#528
Open
VinyarionHyarmendacil wants to merge 3 commits intochromiumembedded:masterfrom
Open
Support persistent & binary queries/callbacks#528VinyarionHyarmendacil wants to merge 3 commits intochromiumembedded:masterfrom
VinyarionHyarmendacil wants to merge 3 commits intochromiumembedded:masterfrom
Conversation
Test case updated as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #398
After trying to (ab)use JNA to manually pre-increment the CefQueryCallback native reference count, I found my way here and discovered that #476 existed, but was made to the wrong repo. This is my approach to solving the problem:
Regarding binary queries/successes:
(javadocs note that the buffer must be direct)Test cases have been added to the "detailed handler test" in MessageRouterHandlerEx and binding_test2.html